Migrate the rest of package:dwds to null safety #1689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
July 13, 2022 11:38
…ll-safety-dwds-debugging4
added 8 commits
July 15, 2022 17:20
…ll-safety-dwds-final
…ll-safety-dwds-final
grouma
approved these changes
Jul 20, 2022
elliette
reviewed
Jul 21, 2022
dwds/lib/dart_web_debug_service.dart
Outdated
| bool launchDevToolsInNewWindow, | ||
| SdkConfigurationProvider sdkConfigurationProvider, | ||
| bool emitDebugEvents, | ||
| // file. Change all occurences of devtools/Devtools to devTools/DevTools. |
There was a problem hiding this comment.
Haha we are both wrong 🤦♀️ Looked it up and it's spelled "occurrences" (two Rs)
There was a problem hiding this comment.
lol I run a spell checker and it is also wrong apparently:) So it is not just us:)
There was a problem hiding this comment.
Assume half the spelling mistakes in this package are mine lol. I can't spell and often forget to enable the spell checker.
There was a problem hiding this comment.
We all contribute:)
I run a spell checker to please the g3 spell checker rules.
added 2 commits
July 21, 2022 09:28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate the rest of package:dwds to null safety
Also, added defaults to all parameters in test setup and removed unused one (discovered nulls passed as parameters due to migration)
Towards: #1327