Migrate configuration.dart and shared.dart to null-safety
#1757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parlough
reviewed
Oct 6, 2022
annagrin
reviewed
Oct 7, 2022
annagrin
reviewed
Oct 7, 2022
There was a problem hiding this comment.
Thanks Elliott! I think you are right that the private fields need to be nullable for the override to work (or we need to require the configuration a bit, which is out of scope of this change). Let's try to make the public configuration getters non-nullable wherever possible.
| @@ -270,17 +268,17 @@ class Configuration { | |||
| /// 'sound', 'unsound', or 'auto'. | |||
| /// 'auto' indicates that the default `package:build_web_compilers` | |||
| /// behavior should be used. | |||
| String get nullSafety => _nullSafety; | |||
| String? get nullSafety => _nullSafety; | |||
There was a problem hiding this comment.
this feels non-nullable - can we return auto if _nullSafety is null?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #1640