Skip to content

Support records #1919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Feb 11, 2023
Merged

Support records #1919

merged 32 commits into from
Feb 11, 2023

Conversation

annagrin
Copy link
Contributor

@annagrin annagrin marked this pull request as draft January 26, 2023 23:11
annagrin
annagrin commented Feb 1, 2023
View reviewed changes
@annagrin annagrin marked this pull request as ready for review February 1, 2023 17:18
@annagrin annagrin requested review from elliette and nshahan February 1, 2023 17:21
annagrin
annagrin commented Feb 1, 2023
View reviewed changes
@annagrin annagrin requested review from nshahan and elliette February 9, 2023 21:34
@annagrin
Copy link
Contributor Author

annagrin commented Feb 9, 2023

@elliette @nshahan I updated this CR (taken out fixes that could be done independently). Now that those fixes are in and the record type fix is released into dev sdk, the PR is ready for another review. Thanks!

annagrin
annagrin commented Feb 9, 2023
View reviewed changes
@annagrin annagrin requested a review from nshahan February 10, 2023 17:11
nshahan
nshahan approved these changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@nshahan nshahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but probably want one from @elliette for more context.

elliette
elliette approved these changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@elliette elliette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once remaining comments are addressed

@annagrin annagrin merged commit 4a41cf9 into dart-lang:master Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nshahan nshahan nshahan approved these changes

@elliette elliette elliette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annagrin @nshahan @elliette