Add experimental test fixtures and tests #1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 27, 2023 12:02
elliette
reviewed
Feb 3, 2023
dwds/test/fixtures/context.dart
Outdated
| @@ -264,6 +265,8 @@ class TestContext { | |||
| '--define', | |||
| 'build_web_compilers|ddc=generate-full-dill=true', | |||
| ], | |||
| for (var experiment in experiments) | |||
There was a problem hiding this comment.
nit: for (final experiment...
elliette
reviewed
Feb 3, 2023
| @@ -199,6 +199,7 @@ class TestContext { | |||
| bool launchChrome = true, | |||
| bool isFlutterApp = false, | |||
| bool isInternalBuild = false, | |||
| List<String> experiments = const <String>[], | |||
There was a problem hiding this comment.
I feel like this parameter makes more sense as part of the TestContext constructors since the experiments are tied to the package being used
There was a problem hiding this comment.
I am not sure they are always tied to the package - I can imagine an experiment that does not need changes to the code, just the compilation of it. I'll ask Nick to confirm.
There was a problem hiding this comment.
Confirmed with Nick, indeed we can have experiments that work on the same code.
elliette
reviewed
Feb 3, 2023
elliette
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards: dart-lang/sdk#49728
--enable-experimentsflag to the frontend server and ddc._experimentSoundtest fixture.