Skip to content

[MV3 Debug Extension] Add missing elements and IDs to inspector panel #1946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2023
Merged

[MV3 Debug Extension] Add missing elements and IDs to inspector panel #1946

merged 1 commit into from
Feb 9, 2023

Conversation

elliette
Copy link
Contributor

@elliette elliette commented Feb 8, 2023

The panel.dart expects us to have a landingPage and loadingSpinner

@elliette elliette requested a review from annagrin February 8, 2023 23:19
annagrin
annagrin approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elliette elliette merged commit fff4865 into dart-lang:master Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annagrin annagrin annagrin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elliette @annagrin