[MV3 Debug Extension] Compile extension with Dart instead of shell script #1954
Conversation
elliette
changed the title
| void logOutput(ProcessResult result) { | ||
| final output = result.stdout; | ||
| final outputList = output is List ? output : [output ?? '']; | ||
| print(outputList.map((output) => '$output').join('\n')); |
There was a problem hiding this comment.
Can we switch to using transformers on the stream to listen to lines instead and logging them one by one? That way we can see the output in progress, even if the process never ends, for example. Also it will allow us to fail early if needed.
There was a problem hiding this comment.
Looking at the documentation:
"Use the static start and run methods to start a new process. The run method executes the process non-interactively to completion. In contrast, the start method allows your code to interact with the running process."
Process.start returns a Process with stdout and stderr streams that can be listened to. I think it makes more sense to use Process.run here.
| ), | ||
| ); | ||
| logInfo('Updating manifest.json in /compiled directory.'); | ||
| logOutput( |
There was a problem hiding this comment.
Can we add printing on errors, for example if the exist code is not 0? Or maybe return the exit code from run so the caller can check it?
There was a problem hiding this comment.
Added, now checking if the exit code is not 0, and is so printing the stderr.
| } | ||
|
|
||
| void logOutput(ProcessResult result) { | ||
| final output = result.stdout; |
There was a problem hiding this comment.
Probably need to log the stderr as well.
Suggestion - use transformers to listen to both and use a logger to report severe errors on failures (for example, any message from stderr, non-0 exit codes, or [SEVERE] output on stdout)
There was a problem hiding this comment.
Logging stderr if the exit code is not 0, and also terminating the entire process with that exit code.
| ); | ||
| final updateExitCode = await _handleProcess(updateStep); | ||
| // Terminate early if updating dev files failed: | ||
| if (updateExitCode != 0) { |
There was a problem hiding this comment.
Also, can we log that the process exited abnormally?
There was a problem hiding this comment.
updateExitCode is being returned, and logging happens in main (line 29-30)
There was a problem hiding this comment.
I meant that this logic (lines 53-57) can be simplified to just "return updateExitCode`, but that is optional
| ); | ||
| final updateExitCode = await _handleProcess(updateStep); | ||
| // Terminate early if updating dev files failed: | ||
| if (updateExitCode != 0) { |
There was a problem hiding this comment.
I meant that this logic (lines 53-57) can be simplified to just "return updateExitCode`, but that is optional
| } | ||
|
|
||
| void logWarning(String message) { | ||
| print('[WARNING] $message'); |
There was a problem hiding this comment.
Optional - should we just use a logger(from package:logging/logging.dart) instead of printing?
There was a problem hiding this comment.
Maybe change [WARNING] to [ERROR], to indicate irrecoverable failure?
There was a problem hiding this comment.
Now writing to sdout/stderr following example in https://dart.dev/tutorials/server/cmdline (package:logging/logging.dart wasn't logging to console)
Work towards #1724, #1950