[MV3 Debug Extension] Clean up tests in preparation for supporting compiling to MV2 #1964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

elliette merged 1 commit into dart-lang:master from elliette:test-cleanup

Feb 15, 2023

Contributor

elliette commented Feb 15, 2023

makes some methods that should be private private
adds an evaluate method, which will be used to support both MV2 and MV3
regenerates the screenshots


          Test clean up

ff4adc9

elliette requested a review from annagrin

February 15, 2023 01:40

annagrin approved these changes

View reviewed changes

Contributor

annagrin left a comment

LGTM!

elliette merged commit 3982f5f into dart-lang:master

elliette added a commit to elliette/webdev that referenced this pull request


          Merge in changes from dart-lang#1964

018a508

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet