Skip to content

Move project definitions into a separate class #1975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 22, 2023

Conversation

annagrin
Copy link
Contributor

@annagrin annagrin commented Feb 18, 2023

Test-only change

Move test project definitions out of TestContext

  • Create TestProject with all the existing fixture definitions, in fixtures\project.dart
  • Make TestContext constructor take a project as an argument.
  • Replace all references to hard coded project names and directories with project fields.
  • Update tests to use new TestContext constructor.

Towards: #1985
Related: #1878

@annagrin annagrin mentioned this pull request Feb 18, 2023
13 tasks
@annagrin annagrin requested a review from elliette February 21, 2023 18:24
? TestProject.testCircular2WithSoundNullSafety(baseMode: baseMode)
: TestProject.testCircular2WithWeakNullSafety(baseMode: baseMode);

/// _test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@annagrin annagrin merged commit 0f893e6 into dart-lang:master Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants