Run webdev tests in a copy of the sdk directory #1987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 20 commits
February 13, 2023 15:01
13 tasks
added 3 commits
February 22, 2023 21:10
annagrin
changed the title
This was referenced Feb 23, 2023
elliette
reviewed
Feb 23, 2023
| @@ -37,17 +33,6 @@ Future<String> waitForAppId(TestProcess webdev) async { | |||
| return appId; | |||
| } | |||
|
|
|||
| Future<String> prepareWorkspace() async { | |||
There was a problem hiding this comment.
I remember adding this recently to fix some of the flakes we were hitting for our CI tests on Windows. Is this now done elsewhre?
There was a problem hiding this comment.
Ah I see where it has been moved to, nevermind!
There was a problem hiding this comment.
Yes, it just moved to the test_utils inside TestRunner class, as I needed to run it using correct dart path from the sdk layout.
elliette
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test-only changes
Run webdev tests in a copy of the sdk. This change is a part of moving all of our tests to run in an sdk copy.
runWebdevandprepareWorkspaceinto atestRunnerclass that can create and dispose of the sdk copy.testRunner.Towards: #1985
Related: #1878