Skip to content

[MV3 Debug Extension] Small fixes for building the extension #1990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 24, 2023
Merged

[MV3 Debug Extension] Small fixes for building the extension #1990

merged 2 commits into from
Feb 24, 2023

Conversation

elliette
Copy link
Contributor

  • Skip updating the dev files if we are compiling the prod extension
  • Have the grey icon as the default, and switch to the dart_dev icon if we are compiling for dev
  • Remove "host_permissions": ["<all_urls>"] from the manifest.json for MV2 (only MV3 supports it)

@elliette elliette requested a review from annagrin February 23, 2023 22:35
annagrin
annagrin approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elliette elliette merged commit 057f598 into dart-lang:master Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annagrin annagrin annagrin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elliette @annagrin