Skip to content

[MV3 Debug Extension] Bolt debugging: can reload the page and continue to debug #1991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

elliette
Copy link
Contributor

Fixes an issue for Bolt where Dart DevTools would close if the user refreshed the page while debugging.

This was because:

  • We were comparing the Dart app URL (in this case, the URL of the IFRAME containing the Dart "app") against the URL of the tab (which is the URL for Bolt itself).

Now we:

  • save the tab URL along with the app url
  • compare against the tab URL instead of the app url
  • ignore any internal navigation events (for example, IFRAME reloads, clicking a link, etc...)

Note: No test for the same reason as explained in #1983

@elliette elliette requested a review from annagrin February 23, 2023 23:55
Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants