Update the release script to take into account pubspec_overrides.yaml
#2080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natebosch
reviewed
Apr 6, 2023
tool/release.dart
Outdated
| String package, { | ||
| required bool includeOverrides, | ||
| }) { | ||
| final pubspecOverrides = File('../$package/pubspec_overrides.yaml'); |
There was a problem hiding this comment.
WDYT about temporarily moving the files instead?
Rename it to ignore_pubspec_overrides.yaml during publish, then name it back.
This would allow the file to have comments.
There was a problem hiding this comment.
I like that suggestion! Done.
jakemac53
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A script to automate most of the manual steps of releasing
webdev/dwdswas recently added:dwdsandwebdev#2049As were
pubspec_override.yamlfiles (this was so we wouldn't have to comment-out our dependency overrides when publishing):webdev,dwds,test_commonafter publishing #2048Reading through comments on dart-lang/pub#3782, it seems
pubspec_overridesare used during publishing.Therefore, this PR updates our release script to comment out the overrides when publishing, and un-comment them when resetting the packages after publishing.
Work towards #2085