Skip to content

Simplify class metadata #2102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

annagrin
Copy link
Contributor

Closes: #2101


String classIdFor(String libraryId, String? name) => 'classes|$libraryId|$name';

enum ClassMetaDataKind {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove:)

@natebosch
Copy link
Member

Is this change worth pursuing?

@annagrin
Copy link
Contributor Author

Is this change worth pursuing?

Not really, it is superseded by #2103

@annagrin annagrin closed this May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace boolean fields in ClassMetadata by an instance kind
2 participants