Skip to content

Support using scope in evaluateInFrame #2122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jun 2, 2023
Merged

Support using scope in evaluateInFrame #2122

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
be536ba
Support evaluation on frame with scope
May 24, 2023
d1e242f
Update changelog
May 24, 2023
9f96dc6
Remove old test
May 24, 2023
ae0f55b
Cleanup, add tests and batch JS eval
May 25, 2023
03286a7
Update changelog
May 25, 2023
849d8be
Merge with master
May 31, 2023
e6969f4
Remove obsolete test
May 31, 2023
b7f6587
Try fixing flaky test on windows
May 31, 2023
cd4cab4
Addressed CR comments and simplified scope detection
May 31, 2023
db2d789
Added example in comments
May 31, 2023
9896fef
removed extra line
May 31, 2023
d9c22b9
Revert change done by mistake
May 31, 2023
60ef602
Merge branch 'master' of github.com:dart-lang/webdev into annagrin/ev…
May 31, 2023
8749e27
Cleaned up comments
Jun 1, 2023
459bd3a
Address CR comments
Jun 2, 2023
fbcf596
Fix a bug when adding this to scope
Jun 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dwds/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
- Refactor code for presenting record instances. - [#2074](https://github.com/dart-lang/webdev/pull/2074)
- Display record types concisely. - [#2070](https://github.com/dart-lang/webdev/pull/2070)
- Display type objects concisely. - [#2103](https://github.com/dart-lang/webdev/pull/2103)
- Support using scope in `ChromeProxyService.evaluateInFrame`. - [#2122](https://github.com/dart-lang/webdev/pull/2122)
- Check for new events more often in batched stream. - [#2123](https://github.com/dart-lang/webdev/pull/2123)

## 19.0.0
Expand Down
Loading