[TEST ONLY] Run tests against Dart stable #2228
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
package:webdev
package:dwds
type-infra
annagrin
reviewed
Sep 12, 2023
| @@ -5,7 +5,7 @@ stages: | |||
| - format | |||
| - analyze: --fatal-infos . | |||
| - test: test/build/ensure_version_test.dart | |||
| sdk: dev | |||
| sdk: stable | |||
There was a problem hiding this comment.
i don't think we can do this as we frequently constrain the sdk so only dev version would successfully resolve. We should keep running the master dwds tests agaings dev and main, and add separate cron job tests for stable (just running the webdev e2e tests for now)
There was a problem hiding this comment.
This PR was to test whether we could have caught the regression if we had been running stable tests against our latest release. It's not branched off of master. See #2226 for details / proposal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.