Skip to content

Add evaluation test to webdev to catch issues with runtime debugging API #2250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 13, 2023
Merged

Add evaluation test to webdev to catch issues with runtime debugging API #2250

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
860730a
Add test to catch latest type table failure in DDC
Sep 28, 2023
31f77dd
Add tests that use debugger runtime API
Oct 11, 2023
84a0417
Merge branch 'master' of github.com:dart-lang/webdev into annagribn/a…
Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 72 additions & 0 deletions webdev/test/e2e_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,10 @@ void main() {
var process = await testRunner.runWebDev(args,
workingDirectory:
soundNullSafety ? soundExampleDirectory : exampleDirectory);

process.stdoutStream().listen(Logger.root.fine);
process.stderrStream().listen(Logger.root.warning);

VmService? vmService;

try {
Expand Down Expand Up @@ -412,6 +416,74 @@ void main() {
await process.shouldExit();
}
}, timeout: const Timeout.factor(2));

test('evaluate and get objects', () async {
var openPort = await findUnusedPort();
// running daemon command that starts dwds without keyboard input
var args = [
'daemon',
'web:$openPort',
'--enable-expression-evaluation',
'--verbose',
];
var process = await testRunner.runWebDev(args,
workingDirectory:
soundNullSafety ? soundExampleDirectory : exampleDirectory);

process.stdoutStream().listen(Logger.root.fine);
process.stderrStream().listen(Logger.root.warning);

VmService? vmService;

try {
// Wait for debug service Uri
String? wsUri;
await expectLater(process.stdout, emitsThrough((message) {
wsUri = getDebugServiceUri(message as String);
return wsUri != null;
}));
expect(wsUri, isNotNull);

vmService = await vmServiceConnectUri(wsUri!);
var vm = await vmService.getVM();
var isolateId = vm.isolates!.first.id!;
var isolate = await vmService.getIsolate(isolateId);
var libraryId = isolate.rootLib!.id!;

await vmService.streamListen('Debug');

final result = await vmService.evaluate(
isolateId, libraryId, '[true, false]');
expect(
result,
const TypeMatcher<InstanceRef>().having(
(instance) => instance.classRef?.name,
'class name',
'List<bool>'));

final instanceRef = result as InstanceRef;
final list =
await vmService.getObject(isolateId, instanceRef.id!);
expect(
list,
const TypeMatcher<Instance>().having(
(instance) => instance.classRef?.name,
'class name',
'List<bool>'));

final elements = (list as Instance).elements;
expect(elements, [
const TypeMatcher<InstanceRef>().having(
(instance) => instance.valueAsString, 'value', 'true'),
const TypeMatcher<InstanceRef>().having(
(instance) => instance.valueAsString, 'value', 'false'),
]);
} finally {
await vmService?.dispose();
await exitWebdev(process);
await process.shouldExit();
}
}, timeout: const Timeout.factor(2));
});

group('and --no-enable-expression-evaluation:', () {
Expand Down