Skip to content

Run the Webdev tests daily with the Dart stable SDK #2251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 16, 2023

Conversation

elliette
Copy link
Contributor

@elliette elliette commented Oct 13, 2023

Fixes #2226

This PR adds a Github workflow to run the Webdev tests with the Dart stable SDK on a daily cron job.

The workflow:

  • Sets up the Dart stable SDK
  • Runs dart pub global activate webdev to get the latest Webdev compatible with the stable SDK
  • Gets the activated Webdev version
  • Checks out the Webdev repo at the commit for that version tag
  • Runs all the Webdev tests at that commit

This means that any tests added after the Webdev release was cut will not be included (so the test case added in #2250 won't be run as part of the stable testing until the current dev version of Webdev is the version activated for the Dart stable SDK).

Example workflow run: https://github.com/dart-lang/webdev/actions/runs/6513830745/job/17694130291

@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Oct 13, 2023
@elliette elliette changed the title [test] webdev stable tests Run the Webdev tests daily with the Dart stable SDK Oct 13, 2023
@elliette elliette requested a review from annagrin October 13, 2023 23:22
Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you Elliott!

@elliette elliette merged commit c9e96b7 into dart-lang:master Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: testing strategy using the Dart stable SDK
2 participants