Skip to content

Update CI config #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2021
Merged

Update CI config #110

merged 1 commit into from
Feb 24, 2021

Conversation

wojtekmach
Copy link
Member

No description provided.

@wojtekmach
Copy link
Member Author

wojtekmach commented Feb 23, 2021 •
edited
Loading

Our GitHub workflow file varies slightly across projects so I'd like to use this PR as a blueprint. I'd also like to limit the amount of resources we take from GitHub, namely to start less VMs, unless we have a good reason to. I think just running on oldest Elixir+OTP and on newest Elixir+OTP should be fine the vast majority of time.

Summary of changes:

  • use ubuntu-16.04 for all builds. This makes sure we can use older OTP releases, like 19.x
  • limit build matrix to only oldest support and currently newest Elixir+OTP combination. If this project would be using any specific Elixir/OTP features, we'd extend the matrix accordingly.
  • perform lint tasks (compiling with warnings as errors, checking formatting, checking unused deps) in the same job on the latest combination.

@wojtekmach wojtekmach changed the title wip: Update CI config Update CI config Feb 23, 2021
This was referenced Feb 23, 2021
Merged
Merged
Merged
This was referenced Feb 23, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@wojtekmach wojtekmach merged commit 4bafc26 into master Feb 24, 2021
@wojtekmach wojtekmach deleted the wm-ci branch February 24, 2021 11:34
philss added a commit to philss/floki that referenced this pull request Feb 27, 2021
@philss
Use the latest and oldest supported Elixir+OTP in CI
6aa964e 
This follows dashbitco/mox#110
in the sense that we don't need to test all versions of Elixir+OTP, and
therefore reduce the number of VMs needed to run the suite.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wojtekmach @josevalim