Skip to content

[do-not-merge] Pass additional dnf filters in table_scan #1140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from

Conversation

ayushdg
Copy link
Collaborator

@ayushdg ayushdg commented May 9, 2023

Extends the work in #1130 and #1138 to pass additional dnf filters from the rust side to python.

@codecov-commenter
Copy link

codecov-commenter commented May 12, 2023

Codecov Report

Merging #1140 (9377349) into main (f8b7d05) will decrease coverage by 0.06%.
The diff coverage is 90.62%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #1140      +/-   ##
==========================================
- Coverage   81.43%   81.37%   -0.06%     
==========================================
  Files          78       78              
  Lines        4395     4419      +24     
  Branches      797      806       +9     
==========================================
+ Hits         3579     3596      +17     
  Misses        640      640              
- Partials      176      183       +7     
Impacted Files Coverage Δ
dask_sql/physical/utils/filter.py 78.97% <75.00%> (+1.13%) ⬆️
dask_sql/physical/rel/logical/filter.py 84.84% <100.00%> (ø)
dask_sql/physical/rel/logical/table_scan.py 94.91% <100.00%> (+1.73%) ⬆️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ayushdg
Copy link
Collaborator Author

ayushdg commented Jul 7, 2023

Closing in favor of #1179

@ayushdg ayushdg closed this Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants