Add C compiler to conda environments / recipes #1141
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,6 +22,7 @@ build: | |
|
|
||
| requirements: | ||
| build: | ||
| - {{ compiler('c') }} =11 | ||
|
There was a problem hiding this comment. I set this pin somewhat arbitrarily, but it seems like GCC 11 successfully built the shared object locally for me There was a problem hiding this comment. Would do this by adding a |
||
| - {{ compiler('rust') }} >=1.65.0 | ||
|
There was a problem hiding this comment. Also would move this to There was a problem hiding this comment. Are we still able to specify a lower bound like thing with something like rust_compiler_version:
- '>=1.65'Tried this locally and things seemed to work fine, but not sure if this is just because the compiler version is invalid and getting ignored There was a problem hiding this comment. Think that would work Though it could also make sense to pick a version for reproducibility reasons There was a problem hiding this comment. That's fair, I'll go with the latest version being picked up for now (1.69) and we can revisit if there are any issues around that. |
||
| - setuptools-rust >=1.5.2 | ||
| host: | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Despite this being tightly pinned in conda builds, I don't think there's an easy way to pin gcc in the conda environments?
c-compilerbrings in different compiler packages based on platform, and without the use of conditional selectors I don't think there's a way to pin all of those compiler packages in a single conda environment without causing conflict on at least one platform.cc @jakirkham if you know of a way to achieve this, happy to punt if not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could have different environment files per platform
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that makes sense - I think that for the sake of minimizing environment files to manage, I'm going to leave things as is since CI seems to be passing with GCC left unpinned. If we do run into failures at some point due to leaving it this way, I'd imagine that platform-specific environment files is the best workaround.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that makes sense. Would probably do the same thing
Happy to revisit if it becomes more relevant