Skip to content

Remove sphinx and nbsphinx from requirements.txt file #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yuvipanda opened this issue Nov 18, 2021 · 1 comment · Fixed by #531
Closed

Remove sphinx and nbsphinx from requirements.txt file #523

yuvipanda opened this issue Nov 18, 2021 · 1 comment · Fixed by #531

Comments

@yuvipanda
Copy link
Contributor

yuvipanda commented Nov 18, 2021 •
edited
Loading

These aren't actually required for the package to function, and since setup.py reads requirements.txt, these packages get installed each time someone installs datascience package. This becomes a problem for Jupyterlite (similar to #522) as nbsphinx and sphinx pull in a lot of dependencies, many which can't be installed on jupyterlite
@yuvipanda
Copy link
Contributor Author

@ericvd-ucb this is also required to get the datascience package working on jupyterlite

yuvipanda added a commit that referenced this issue Apr 28, 2022
@yuvipanda
Remove sphinx + nbsphinx from requirements.txt
d144240 
- Moves it to doc-requirements.txt, as they are only required for
  docs building
- Bump the version of the package

Fixes #523
@yuvipanda yuvipanda mentioned this issue Apr 28, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove sphinx + nbsphinx from requirements.txt data-8/datascience
1 participant
@yuvipanda