Skip to content

fixing html bug #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2018
Merged

fixing html bug #315

merged 1 commit into from
May 25, 2018

Conversation

choldgraf
Copy link
Contributor

This fixes a small bug in the HTML generation for Table. It was generating the </tbody> tag for each row, instead of once at the end of all rows.

cc @SamLau95

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 74.869% when pulling 1ef10eb on choldgraf:html_bug into 0047852 on data-8:master.

SamLau95
SamLau95 approved these changes May 25, 2018
View reviewed changes
Copy link
Contributor

@SamLau95 SamLau95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@SamLau95 SamLau95 merged commit eba85b0 into data-8:master May 25, 2018
@adnanhemani adnanhemani mentioned this pull request Jun 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamLau95 SamLau95 SamLau95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@choldgraf @coveralls @SamLau95