Skip to content

asarray partial fix #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

asarray partial fix #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0ec8a6
test case for asarray
ivirshup Mar 11, 2024
192da0a
Partial fix
ivirshup Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion array_api_compat/common/_aliases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,6 @@ def _asarray(
obj = np.asarray(obj).copy()
#print(obj)
return xp.array(obj, dtype=dtype, **copy_kwargs)
return obj

return xp.asarray(obj, dtype=dtype, **kwargs)

Expand Down
11 changes: 11 additions & 0 deletions tests/test_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,17 @@ def test_device(library):
x2 = to_device(x, dev)
assert device(x) == device(x2)

@pytest.mark.parametrize("target_library,func", is_functions.items())
@pytest.mark.parametrize("source_library", is_functions.keys())
def test_asarray(source_library, target_library, func):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to this test. We are going to need to add a lot of tests here for asarray, partly because the test suite only handles things within the scope of the standard, and partly because the test suite itself doesn't test as much as it could (data-apis/array-api-tests#241). We can also adopt the tests from data-apis/array-api-strict#15 (once we have fixed the copy behavior, but I expect that will need to just be part of this overall fix since this is part of that logic).

src_lib = import_(source_library, wrapper=True)
tgt_lib = import_(target_library, wrapper=True)
is_tgt_type = globals()[func]

a = src_lib.asarray([1, 2, 3])
b = tgt_lib.asarray(a)

assert is_tgt_type(b), f"Expected {b} to be a {tgt_lib.ndarray}, but was {type(b)}"

@pytest.mark.parametrize("library", ["cupy", "numpy", "torch", "dask.array"])
def test_to_device_host(library):
Expand Down
Loading