-
Notifications
You must be signed in to change notification settings - Fork 10
ENH: add setdiff1d
#34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
One problem is that these functions make use of |
I would propose |
any thoughts on |
I've never even heard of that function before. I guess if it has a lot of usage it could be proposed too, but otherwise I would assume it's a more niche function that would be more appropriate for this package. Also, isn't it straightforward to implement in terms of |
In scikit-learn they implement both in terms of |
I'd also say that |
These functions look like the most obvious candidates for this library from scikit-learn: https://github.com/scikit-learn/scikit-learn/blob/439ea045ad44e6a09115dc23e9bf23db00ff41de/sklearn/utils/_array_api.py#L931-L982
cc @OmarManzoor @ogrisel @betatim
The text was updated successfully, but these errors were encountered: