MAINT: various backports and tweaks #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crusaderky
commented
Feb 20, 2025
There was a problem hiding this comment.
Ran pixi update. Notably this bumps dask to 2025.2.0.
crusaderky
commented
Feb 20, 2025
| report.exclude_also = [ | ||
| '\.\.\.', | ||
| 'if TYPE_CHECKING:', | ||
| ] |
There was a problem hiding this comment.
Caused large sections of code to be incorrectly skipped
crusaderky
commented
Feb 20, 2025
| @@ -33,7 +33,7 @@ def in1d( | |||
| https://github.com/numpy/numpy/blob/v1.26.0/numpy/lib/arraysetops.py#L524-L758 | |||
| """ | |||
| if xp is None: | |||
| xp = _compat.array_namespace(x1, x2) | |||
| xp = array_namespace(x1, x2) | |||
There was a problem hiding this comment.
Note: this causes coverage to fail, as this line isn't covered by unit tests
crusaderky
commented
Feb 20, 2025
| @@ -5,6 +5,7 @@ | |||
| # To be changed to a Protocol later (see data-apis/array-api#589) | |||
| Array = Any # type: ignore[no-any-explicit] | |||
| Device = Any # type: ignore[no-any-explicit] | |||
| DType = Any # type: ignore[no-any-explicit] | |||
crusaderky
commented
Feb 20, 2025
Comment on lines
+134
to
+142
| @pytest.fixture(params=[Backend.DASK]) # Can select the test with `pytest -k dask` | ||
| def da( | ||
| request: pytest.FixtureRequest, monkeypatch: pytest.MonkeyPatch | ||
| ) -> ModuleType: # numpydoc ignore=PR01,RT01 | ||
| """Variant of the `xp` fixture that only yields dask.array.""" | ||
| xp = pytest.importorskip("dask.array") | ||
| xp = array_namespace(xp.empty(0)) | ||
| patch_lazy_xp_functions(request, monkeypatch, xp=xp) | ||
| return xp |
This was referenced Feb 20, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various generic improvements backported from #141 and #86