Skip to content

DOC: clarify at() patterns/antipatterns #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

crusaderky
Copy link
Contributor

@lucascolley
Copy link
Member

could you review @ev-br ?

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @crusaderky. This language looks pretty clear to me.

Copy link
Member

@ev-br ev-br left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than one optional nit, LGTM. Reads much better!

Copy link
Member

@lucascolley lucascolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@lucascolley lucascolley added the documentation Improvements or additions to documentation label Jan 7, 2025
@lucascolley lucascolley merged commit a96dffb into data-apis:main Jan 7, 2025
8 checks passed
@crusaderky crusaderky deleted the at_docs branch January 7, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants