Skip to content

MAINT: mapping f-strings #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 10, 2022
Merged

MAINT: mapping f-strings #136

merged 1 commit into from
Aug 10, 2022

Conversation

tylerjereddy
Copy link
Contributor

  • EqualityMapping was missing some f-strings that I needed
    while testing the conformance of the pykokkos library with
    the array API standard

@tylerjereddy
MAINT: mapping f-strings
384bd0f 
* `EqualityMapping` was missing some f-strings that I needed
while testing the conformance of the `pykokkos` library with
the array API standard
honno
honno approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@honno honno left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

On our end, it might be worth adding a (very conservatively configured) style linter to our pre-commit which can pick up on this kind of stuff.

@honno honno merged commit 4d9d7b4 into data-apis:master Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@honno honno honno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tylerjereddy @honno