Skip to content

PR: Add smallest normal to finfo class #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 14, 2021

Conversation

steff456
Copy link
Member

@steff456 steff456 commented Jun 8, 2021

This PR adds the smallest_normal attribute to the finfo class taking into account the discussion in issue #131.

@steff456 steff456 added the API change Changes to existing functions or objects in the API. label Jun 8, 2021
@steff456 steff456 requested review from rgommers and kgryte June 8, 2021 20:47
@steff456 steff456 self-assigned this Jun 8, 2021
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @steff456

Copy link
Contributor

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rgommers rgommers merged commit 8da3d42 into data-apis:main Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API change Changes to existing functions or objects in the API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants