Skip to content

Add note concerning subnormal numbers #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2021
Merged

Add note concerning subnormal numbers #341

merged 1 commit into from
Dec 6, 2021

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Dec 6, 2021

This PR

  • resolves Improve subnormal expectations #339.
  • relaxes IEEE 754 requirements for supporting subnormal numbers.
  • stems from the need to allow conforming implementations to disable subnormal number support for performance and/or security reasons.

@kgryte kgryte added the API change Changes to existing functions or objects in the API. label Dec 6, 2021
@kgryte kgryte added this to the v2021 milestone Dec 6, 2021
honno
honno approved these changes Dec 6, 2021
View reviewed changes
Copy link
Member

@honno honno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Happy to see this PR 😅

@kgryte
Copy link
Contributor Author

kgryte commented Dec 6, 2021

Thanks, @honno!

@kgryte
Copy link
Contributor Author

kgryte commented Dec 6, 2021

The changes in this PR have been discussed elsewhere. Will merge. Any further changes can be addressed in follow-up PRs.

@kgryte kgryte merged commit 0602a5f into main Dec 6, 2021
@kgryte kgryte deleted the subnormals branch December 6, 2021 19:46
@leofang
Copy link
Contributor

leofang commented Dec 6, 2021

cc: @oleksandr-pavlyk for vis

@honno honno mentioned this pull request Dec 8, 2021
Merged
@kgryte kgryte mentioned this pull request Mar 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@honno honno honno approved these changes

Assignees
No one assigned
Labels
API change Changes to existing functions or objects in the API.
Projects
None yet
Milestone
v2021
Development

Successfully merging this pull request may close these issues.

Improve subnormal expectations
3 participants
@kgryte @leofang @honno