Skip to content

Specify numeric arrays for argmin and argmax #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2021
Merged

Specify numeric arrays for argmin and argmax #342

merged 1 commit into from
Dec 8, 2021

Conversation

honno
Copy link
Member

@honno honno commented Dec 8, 2021

Remains consistent with min and max.

@kgryte kgryte added API change Changes to existing functions or objects in the API. Maintenance Bug fix, typo fix, or general maintenance. topic: Statistics Statistics. labels Dec 8, 2021
@kgryte kgryte added this to the v2021 milestone Dec 8, 2021
kgryte
kgryte approved these changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @honno!

@kgryte kgryte merged commit a854ff1 into data-apis:main Dec 8, 2021
@honno honno deleted the argminmax-numeric branch November 1, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
API change Changes to existing functions or objects in the API. Maintenance Bug fix, typo fix, or general maintenance. topic: Statistics Statistics.
Projects
None yet
Milestone
v2021
Development

Successfully merging this pull request may close these issues.
2 participants
@honno @kgryte