Skip to content

Fix description for trunc #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2022
Merged

Fix description for trunc #511

merged 1 commit into from
Nov 17, 2022

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Nov 17, 2022 •
edited
Loading

This PR

  • fixes the description for trunc. Currently, the description is incorrect for negative numbers (e.g., according to the description, -1.5 should round to -2.0 rather than -1.0).
  • this was an oversight during review of gh-12.

@kgryte kgryte added bug Something isn't working. Maintenance Bug fix, typo fix, or general maintenance. labels Nov 17, 2022
@kgryte kgryte added this to the v2022 milestone Nov 17, 2022
honno
honno approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@honno honno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, LGTM.

@kgryte kgryte merged commit 1229f06 into main Nov 17, 2022
@kgryte kgryte deleted the fix-trunc-desc branch November 17, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@honno honno honno approved these changes

Assignees
No one assigned
Labels
bug Something isn't working. Maintenance Bug fix, typo fix, or general maintenance.
Projects
None yet
Milestone
v2022
Development

Successfully merging this pull request may close these issues.
2 participants
@kgryte @honno