Skip to content

Add note to to_device regarding copy behavior when moving to same device #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Feb 8, 2024

This PR

cc @leofang @rgommers

@kgryte kgryte added this to the v2023 milestone Feb 8, 2024
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kgryte. This is a straightforward clarification, so can be merged as is I believe. A potential new copy= keyword can always be added later, this PR doesn't change that.

@rgommers rgommers added topic: Device Handling Device handling. Maintenance Bug fix, typo fix, or general maintenance. labels Feb 8, 2024
@rgommers rgommers merged commit a902944 into data-apis:main Feb 9, 2024
@rgommers
Copy link
Member

rgommers commented Feb 9, 2024

In it goes then, thanks both!

@kgryte kgryte deleted the docs/to_device branch February 13, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Bug fix, typo fix, or general maintenance. topic: Device Handling Device handling.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

to_device should not copy when the operation is a no op
3 participants