Skip to content

feat: add reciprocal to the specification #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented May 2, 2024

This PR

  • resolves RFC: add reciprocal for computing the element-wise reciprocal #790 by adding support for computing the reciprocal to the specification.
  • requires that special cases be handled as if implemented as 1.0 / x.
  • adopts the same "type promotion" language as other unary element-wise APIs, which is based on the premise that an input array promotes to itself. If this language should be changed, we should do as part of a follow-up PR across all relevant element-wise APIs.
  • requires ("should") that the input array have a floating-point data type, as the output array should have a floating-point data type and promotion of mixed kinds is left unspecified.

Unverified

No user is associated with the committer email.
@kgryte kgryte added the API extension Adds new functions or objects to the API. label May 2, 2024
@kgryte kgryte added this to the v2024 milestone May 2, 2024
@kgryte
Copy link
Contributor Author

kgryte commented Jul 25, 2024

As this addition was previously discussed during workgroup meetings, consensus was in favor of its conclusion--the API having been implemented across array libraries--and no objections have been made, I will go ahead and merge. This will allow test suite and compat work to move forward to allow us to snuff out any potential edge cases before 2024 revision finalization.

@kgryte kgryte merged commit b569b03 into data-apis:main Jul 25, 2024
3 checks passed
@kgryte kgryte deleted the feat/reciprocal branch July 25, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API extension Adds new functions or objects to the API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: add reciprocal for computing the element-wise reciprocal
1 participant