feat: compile site metadata #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orvn
requested changes
Sep 12, 2023
There was a problem hiding this comment.
Looks good! The only issue is that for some reason, the open graph image comes through as an empty string?
weird... the correct urls are there in meta tags: @orvn do you think it has something to do with the preview url hash not matching the site url with the singularity.storage domain? |
orvn
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two plugins to help compile SEO and site metadata which is passed to the Nuxt 3 native composable
useHead()which adds this data to the html document head tag.The two plugins
get-seo.jsandcompile-seo.jshave been copied from our Nuxt 2 boilerplate with only slight adjustments to accommodate a new store structure with the Pinia store and the config object in Nuxt 3. A wrapping function around each has also been included as Nuxt 3 needs this in order to properly inject the functions into the app scope.Also site content is now added to the store once fetched with the
useAsyncDatacomposable and from there is used throughout the app rather than accessing data directly from imported json objects.Ticket link
https://www.notion.so/agencyundone/Open-graph-and-metadata-via-Nuxt-3-00cba4168fa2487fae3efe1f001b3563?pvs=4