Skip to content

feat(function): Add list Aggregate function #10708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented Mar 22, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Add list Aggregate function

Part of #10497

@b41sh b41sh requested a review from sundy-li March 22, 2023 07:41
@vercel
Copy link

vercel bot commented Mar 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
databend ⬜️ Ignored (Inspect) Visit Preview Mar 22, 2023 at 9:03AM (UTC)

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Mar 22, 2023
@BohuTANG
Copy link
Member

[SQL] SHOW GRANTS FOR 'test-grant'@'localhost'
[Diff] (-expected|+actual)
    GRANT ALL ON 'default'.'default'.* TO 'test-grant'@'localhost'
    GRANT SELECT ON 'default'.'db01'.* TO 'test-grant'@'localhost'
-   GRANT SELECT ON 'default'.'db01'.'tb1' TO 'test-grant'@'localhost'
-   GRANT SELECT ON 'default'.'system'.'one' TO 'test-grant'@'localhost'
+   GRANT SELECT ON 'default'.'db01'.'tb1' TO 'test-grant'@'localhost'
at tests/sqllogictests/suites/base/05_ddl/05_0006_ddl_grant_privilege:49

The failure has been seen most times, it's time to fix it, cc @TCeason

@TCeason
Copy link
Collaborator

TCeason commented Mar 22, 2023

[SQL] SHOW GRANTS FOR 'test-grant'@'localhost'
[Diff] (-expected|+actual)
    GRANT ALL ON 'default'.'default'.* TO 'test-grant'@'localhost'
    GRANT SELECT ON 'default'.'db01'.* TO 'test-grant'@'localhost'
-   GRANT SELECT ON 'default'.'db01'.'tb1' TO 'test-grant'@'localhost'
-   GRANT SELECT ON 'default'.'system'.'one' TO 'test-grant'@'localhost'
+   GRANT SELECT ON 'default'.'db01'.'tb1' TO 'test-grant'@'localhost'
at tests/sqllogictests/suites/base/05_ddl/05_0006_ddl_grant_privilege:49

The failure has been seen most times, it's time to fix it, cc @TCeason

Yes, I try to reproduce this on local, but I can not reproduce it. So I add more info in this pr: #10705.

@TCeason
Copy link
Collaborator

TCeason commented Mar 22, 2023

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Mar 22, 2023

update

✅ Branch has been successfully updated

@BohuTANG BohuTANG merged commit 379bb89 into databendlabs:main Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants