-
Notifications
You must be signed in to change notification settings - Fork 774
refactor: add query_profile
and query_details
persistent log tables
#17702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (1)
- tests/logging/check_logs_table.sh: Language not supported
Comments suppressed due to low confidence (3)
src/query/service/src/persistent_log/global_persistent_log.rs:242
- [nitpick] Consider quoting the table_name with backticks for consistency with the rename_target formatting to prevent potential SQL parsing issues.
let rename = format!("ALTER TABLE persistent_system.{} RENAME TO {}", table_name, rename_target);
src/common/tracing/src/init.rs:386
- The removal of the cfg.profile.dir.is_empty() check may enable profile logging even when no profile directory is configured; please verify that this change is intentional.
if cfg.profile.on {
src/common/tracing/src/init.rs:393
- Similarly, the removal of the cfg.query.dir.is_empty() check could enable query logging without a proper directory setting; ensure that this behavior is expected.
if cfg.query.on {
zhang2014
reviewed
Apr 9, 2025
35588e7
to
137cff0
Compare
zhang2014
reviewed
Apr 13, 2025
96f16ad
to
e253167
Compare
1861727
to
6a9c323
Compare
Docker Image for PR
|
This reverts commit b17e25f.
zhang2014
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
This PR included:
query_profile
andquery_details
We will have three tables (if enable in config):
Tests
Type of change
This change is