Skip to content

[metasrv] refactor: organized integration test in the rust-crate style: move flight api test into metasrv/tests/ #1915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Sep 22, 2021

I hereby agree to the terms of the CLA available at: https://databend.rs/policies/cla/

Summary

[metasrv] refactor: organized integration test in the rust-crate style: move flight api test into metasrv/tests/

Changelog

  • Improvement

Related Issues

Rust-crate-style tests guide: https://matklad.github.io/2021/02/27/delete-cargo-integration-tests.html

@drmingdrmer drmingdrmer added the A-meta Area: databend meta serive label Sep 22, 2021
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

4 similar comments
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@drmingdrmer drmingdrmer force-pushed the it branch 2 times, most recently from 5bafe51 to 4d84d5e Compare September 22, 2021 07:12
@drmingdrmer drmingdrmer marked this pull request as ready for review September 22, 2021 07:13
Copy link
Member

@dantengsky dantengsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2021

Codecov Report

Merging #1915 (3966769) into master (46c6cc2) will decrease coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #1915    +/-   ##
=======================================
- Coverage      71%     70%    -1%     
=======================================
  Files         645     643     -2     
  Lines       38687   38230   -457     
=======================================
- Hits        27588   27093   -495     
- Misses      11099   11137    +38     
Impacted Files Coverage Δ
metasrv/src/api/flight_server.rs 11% <0%> (-82%) ⬇️
metasrv/src/api/http_service.rs 14% <0%> (-62%) ⬇️
metasrv/src/api/http_service_test.rs 64% <0%> (-4%) ⬇️
common/datavalues/src/series/series_impl.rs 84% <0%> (-2%) ⬇️
metasrv/src/meta_service/network.rs 74% <0%> (+1%) ⬆️
query/src/common/mod.rs 85% <0%> (+2%) ⬆️
store/src/api/http_service_test.rs 68% <0%> (+4%) ⬆️
store/src/api/http_service.rs 76% <0%> (+61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46c6cc2...3966769. Read the comment docs.

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot databend-bot merged commit 0c82e29 into databendlabs:master Sep 22, 2021
@drmingdrmer drmingdrmer deleted the it branch September 22, 2021 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: databend meta serive
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants