Skip to content

[test] apply the new test style to common_functions #2631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2021

Conversation

PsiACE
Copy link
Member

@PsiACE PsiACE commented Nov 3, 2021

Signed-off-by: Chojan Shang [email protected]

I hereby agree to the terms of the CLA available at: https://databend.rs/policies/cla/

Summary

apply the new test style to common_functions

Changelog

  • Build/Testing/CI
  • Not for changelog (changelog entry is not required)

Related Issues

Related #1866

Test Plan

Unit Tests

Stateless Tests

@databend-bot databend-bot added pr-build this PR changes build/testing/ci steps pr-not-for-changelog labels Nov 3, 2021
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@codecov-commenter
Copy link

Codecov Report

Merging #2631 (f3f7d97) into main (4464dfb) will decrease coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2631     +/-   ##
=======================================
- Coverage     72%     71%     -2%     
=======================================
  Files        650     627     -23     
  Lines      36623   34147   -2476     
=======================================
- Hits       26508   24309   -2199     
+ Misses     10115    9838    -277     
Impacted Files Coverage Δ
common/functions/src/scalars/arithmetics/mod.rs 100% <ø> (ø)
...tions/src/aggregates/aggregate_function_factory.rs 75% <0%> (-16%) ⬇️
common/functions/src/scalars/strings/substring.rs 79% <0%> (-8%) ⬇️
common/datavalues/src/columns/data_column.rs 69% <0%> (-3%) ⬇️
common/datavalues/src/data_value.rs 40% <0%> (-2%) ⬇️
...ctions/tests/it/aggregates/aggregate_combinator.rs
...unctions/tests/it/aggregates/aggregate_function.rs
common/functions/tests/it/scalars/arithmetic.rs
common/functions/tests/it/scalars/comparison.rs
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4464dfb...f3f7d97. Read the comment docs.

Signed-off-by: Chojan Shang <[email protected]>
@PsiACE PsiACE marked this pull request as ready for review November 3, 2021 15:11
@PsiACE
Copy link
Member Author

PsiACE commented Nov 3, 2021

Since some of the modules have only one set of tests, there is no need to continue splitting them. Splitting will be done when necessary.

@PsiACE PsiACE requested review from BohuTANG and sundy-li November 3, 2021 15:15
@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot databend-bot merged commit 1367213 into databendlabs:main Nov 4, 2021
@PsiACE PsiACE deleted the func-test branch November 5, 2021 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-build this PR changes build/testing/ci steps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants