Skip to content

[test] apply the new test style to common-dal #2747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

PsiACE
Copy link
Member

@PsiACE PsiACE commented Nov 11, 2021

Signed-off-by: Chojan Shang [email protected]

I hereby agree to the terms of the CLA available at: https://databend.rs/policies/cla/

Summary

apply the new test style to common-dal

Changelog

  • Improvement
  • Not for changelog (changelog entry is not required)

Related Issues

Related #1866

Test Plan

Unit Tests

Stateless Tests

@PsiACE PsiACE requested a review from dantengsky November 11, 2021 08:49
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@codecov-commenter
Copy link

Codecov Report

Merging #2747 (14a137a) into main (68bbe71) will increase coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##            main   #2747    +/-   ##
======================================
  Coverage     69%     69%            
======================================
  Files        617     614     -3     
  Lines      32881   32697   -184     
======================================
- Hits       22695   22668    -27     
+ Misses     10186   10029   -157     
Impacted Files Coverage Δ
common/dal/src/schemes.rs 90% <0%> (-10%) ⬇️
common/datavalues/src/series/series_impl.rs 84% <0%> (-2%) ⬇️
common/datavalues/src/data_value.rs 41% <0%> (-1%) ⬇️
common/dal/tests/it/impls/aws_s3.rs
common/dal/tests/it/impls/azure_blob.rs
common/dal/tests/it/schemes.rs

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68bbe71...14a137a. Read the comment docs.

@dantengsky
Copy link
Member

/LGTM

@databend-bot
Copy link
Member

Wait for another reviewer approval

@databend-bot
Copy link
Member

CI Passed
Reviewers Approved
Let's Merge
Thank you for the PR @PsiACE

@drmingdrmer drmingdrmer merged commit fbcfa1d into databendlabs:main Nov 11, 2021
@PsiACE PsiACE deleted the dal-test branch November 29, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants