Skip to content

[test] apply the new test style to common-infallible #2772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2021

Conversation

PsiACE
Copy link
Member

@PsiACE PsiACE commented Nov 13, 2021

Signed-off-by: Chojan Shang [email protected]

I hereby agree to the terms of the CLA available at: https://databend.rs/policies/cla/

Summary

apply the new test style to common-infallible

Changelog

  • Improvement
  • Not for changelog (changelog entry is not required)

Related Issues

Related #1866

Test Plan

Unit Tests

Stateless Tests

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@BohuTANG
Copy link
Member

/lgtm

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2021

Codecov Report

Merging #2772 (8512638) into main (91dd5f1) will decrease coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2772   +/-   ##
=====================================
- Coverage     69%     69%   -1%     
=====================================
  Files        603     601    -2     
  Lines      32521   32487   -34     
=====================================
- Hits       22728   22635   -93     
- Misses      9793    9852   +59     
Impacted Files Coverage Δ
metasrv/src/api/http_service.rs 8% <0%> (-55%) ⬇️
common/base/src/http_shutdown_handlers.rs 11% <0%> (-53%) ⬇️
metasrv/src/api/http_service_test.rs 64% <0%> (-20%) ⬇️
common/datavalues/src/series/series_impl.rs 84% <0%> (-2%) ⬇️
query/src/clusters/cluster.rs 54% <0%> (-2%) ⬇️
common/infallible/tests/it/mutex.rs
common/infallible/tests/it/rwlock.rs
metasrv/src/meta_service/network.rs 78% <0%> (+1%) ⬆️
common/management/src/cluster/cluster_mgr.rs 81% <0%> (+2%) ⬆️
query/src/common/mod.rs 70% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91dd5f1...8512638. Read the comment docs.

@BohuTANG BohuTANG merged commit 0346358 into databendlabs:main Nov 13, 2021
@PsiACE PsiACE deleted the infallible-tests branch November 29, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants