Skip to content

[test] apply the new test style to 'common/meta' #2791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 16, 2021

Conversation

PsiACE
Copy link
Member

@PsiACE PsiACE commented Nov 15, 2021

I hereby agree to the terms of the CLA available at: https://databend.rs/policies/cla/

Summary

[test] apply the new test style to 'common/meta'

Changelog

  • Improvement
  • Not for changelog (changelog entry is not required)

Related Issues

Related #1866

Test Plan

Unit Tests

Stateless Tests

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2021

Codecov Report

Merging #2791 (ac89f57) into main (2cbfa94) will increase coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2791   +/-   ##
=====================================
  Coverage     69%     69%           
=====================================
  Files        601     600    -1     
  Lines      32728   32803   +75     
=====================================
+ Hits       22801   22866   +65     
- Misses      9927    9937   +10     
Impacted Files Coverage Δ
query/src/common/mod.rs 70% <0%> (-15%) ⬇️
query/src/interpreters/interpreter_use_database.rs 92% <0%> (-8%) ⬇️
query/src/interpreters/interpreter_insert_into.rs 87% <0%> (-7%) ⬇️
cli/src/error.rs 30% <0%> (-2%) ⬇️
query/src/datasources/table/fuse/table_test.rs 94% <0%> (-2%) ⬇️
...y/src/datasources/table/fuse/index/min_max_test.rs 91% <0%> (-1%) ⬇️
query/src/catalogs/table.rs 66% <0%> (-1%) ⬇️
common/datavalues/src/arrays/primitive/mod.rs 61% <0%> (-1%) ⬇️
query/src/configs/config_storage.rs 87% <0%> (-1%) ⬇️
common/planners/src/plan_read_datasource.rs 80% <0%> (-1%) ⬇️
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cbfa94...ac89f57. Read the comment docs.

@PsiACE PsiACE marked this pull request as ready for review November 15, 2021 07:29
Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It smells good!

@databend-bot
Copy link
Member

Wait for another reviewer approval

@BohuTANG
Copy link
Member

/lgtm

@databend-bot
Copy link
Member

CI Passed
Reviewers Approved
Let's Merge
Thank you for the PR @PsiACE

@BohuTANG BohuTANG merged commit 4d6b0ae into databendlabs:main Nov 16, 2021
@PsiACE PsiACE deleted the meta-tests branch November 29, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants