Skip to content

[test] apply the new test style to databend-meta #2814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 16, 2021

Conversation

PsiACE
Copy link
Member

@PsiACE PsiACE commented Nov 16, 2021

Signed-off-by: Chojan Shang [email protected]

I hereby agree to the terms of the CLA available at: https://databend.rs/policies/cla/

Summary

[test] apply the new test style to databend-meta

Changelog

  • Improvement
  • Not for changelog (changelog entry is not required)

Related Issues

Related #1866

Test Plan

Unit Tests

Stateless Tests

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

1 similar comment
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@codecov-commenter
Copy link

Codecov Report

Merging #2814 (a31907e) into main (12e4bb0) will decrease coverage by 1%.
The diff coverage is n/a.

❗ Current head a31907e differs from pull request most recent head 7cc8b4a. Consider uploading reports for the commit 7cc8b4a to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2814     +/-   ##
=======================================
- Coverage     69%     67%     -2%     
=======================================
  Files        600     575     -25     
  Lines      32294   31191   -1103     
=======================================
- Hits       22387   21030   -1357     
- Misses      9907   10161    +254     
Impacted Files Coverage Δ
...nctions/src/scalars/arithmetics/arithmetic_plus.rs 42% <0%> (-58%) ⬇️
common/meta/raft-store/src/state/raft_state.rs 26% <0%> (-56%) ⬇️
metasrv/src/meta_service/raftmeta.rs 47% <0%> (-39%) ⬇️
common/meta/types/src/raft_types.rs 16% <0%> (-34%) ⬇️
...unctions/src/scalars/arithmetics/arithmetic_div.rs 70% <0%> (-30%) ⬇️
...unctions/src/scalars/arithmetics/arithmetic_mul.rs 70% <0%> (-30%) ⬇️
...ctions/src/scalars/arithmetics/arithmetic_minus.rs 70% <0%> (-30%) ⬇️
...tions/src/scalars/arithmetics/arithmetic_modulo.rs 70% <0%> (-30%) ⬇️
common/functions/src/scalars/function.rs 31% <0%> (-29%) ⬇️
common/meta/raft-store/src/log/raft_log.rs 73% <0%> (-27%) ⬇️
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12e4bb0...7cc8b4a. Read the comment docs.

Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we gonna have a tutorial of 'best practice', these patches should be part of it. XDDD

@databend-bot
Copy link
Member

Wait for another reviewer approval

@drmingdrmer drmingdrmer merged commit 56f4276 into databendlabs:main Nov 16, 2021
@PsiACE PsiACE deleted the metasrv-tests branch November 29, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants