Skip to content

[test] apply the new test style to databend-query #2934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 17 commits into from

Conversation

PsiACE
Copy link
Member

@PsiACE PsiACE commented Nov 21, 2021

I hereby agree to the terms of the CLA available at: https://databend.rs/policies/cla/

Summary

Needs a little more time to be done:

  • [test] apply the new test style to databend-query

Changelog

  • Improvement
  • Not for changelog (changelog entry is not required)

Related Issues

I think this is the last module, so if I've missed anything, please point it out.

Fixes #1866

Test Plan

Unit Tests

Stateless Tests

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2021

Codecov Report

Merging #2934 (5293672) into main (1af20a3) will decrease coverage by 8%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2934     +/-   ##
=======================================
- Coverage     68%     59%     -9%     
=======================================
  Files        636     530    -106     
  Lines      33643   28924   -4719     
=======================================
- Hits       22975   17237   -5738     
- Misses     10668   11687   +1019     
Impacted Files Coverage Δ
query/src/api/rpc_service.rs 65% <ø> (ø)
query/src/sql/parser/ast/mod.rs 12% <ø> (-5%) ⬇️
query/src/sql/parser/transformer/mod.rs 100% <ø> (ø)
query/src/datasources/index/mod.rs 0% <0%> (-100%) ⬇️
query/src/common/hashtable/hash_table_key.rs 0% <0%> (-100%) ⬇️
query/src/common/hashtable/hash_table_iter.rs 0% <0%> (-100%) ⬇️
common/functions/src/scalars/arithmetics/mod.rs 0% <0%> (-100%) ⬇️
...ry/src/datasources/table/fuse/util/col_encoding.rs 0% <0%> (-100%) ⬇️
...ry/src/datasources/table/fuse/util/location_gen.rs 0% <0%> (-100%) ⬇️
query/src/datasources/table/fuse/read_plan.rs 0% <0%> (-98%) ⬇️
... and 217 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1af20a3...5293672. Read the comment docs.

@PsiACE
Copy link
Member Author

PsiACE commented Nov 24, 2021

We are currently making more changes to the query and I will replace it with some smaller PRs. For now, let's close it.

@PsiACE PsiACE closed this Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New testing style in Rust crate
3 participants