Skip to content

feat: Add default role, force ALTER/CREATE USER enable planner v2 #6847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Aug 4, 2022
Merged

feat: Add default role, force ALTER/CREATE USER enable planner v2 #6847

merged 32 commits into from
Aug 4, 2022

Conversation

flaneur2020
Copy link
Member

@flaneur2020 flaneur2020 commented Jul 27, 2022 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  • add default_role into pb
  • refactor: remove User struct, which only used in a test case file
  • add default_role into UserOption
  • syntax about alter user set default_role =
  • ensure only root can ALTER USER xxx WITH flags next pr
  • display default_role in SHOW USERS
  • force ALTER/CREATE USER take planner v2
  • add sqlogictest about ALTER USER
  • add sqlogictest about CREATE USER
  • test about serialization on default_role
  • verify before set default role in next pr
  • fix test_load_old_user
  • await refactor: Dedicate See you again to the old planner #6895 merged

Fixes #6843
Fixes #6897
Fixes #6896

@vercel
Copy link

vercel bot commented Jul 27, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Aug 4, 2022 at 11:13AM (UTC)

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Jul 27, 2022
@flaneur2020 flaneur2020 force-pushed the add-default-role branch 2 times, most recently from 6e90af8 to c3a2337 Compare July 27, 2022 10:47
@flaneur2020 flaneur2020 marked this pull request as ready for review July 28, 2022 10:51
@flaneur2020 flaneur2020 requested a review from drmingdrmer as a code owner July 28, 2022 10:51
@flaneur2020 flaneur2020 changed the title feat: Add default role feat: Add default role, force ALTER/CREATE USER enable planner v2 Jul 28, 2022
@flaneur2020
Copy link
Member Author

flaneur2020 commented Jul 28, 2022 •
edited
Loading

@Xuanwo @junnplus @youngsofun can you help review this pull request?

Xuanwo
Xuanwo reviewed Jul 28, 2022
View reviewed changes
@BohuTANG
Copy link
Member

Conflicting files
tests/logictest/logictest.py

@flaneur2020 flaneur2020 mentioned this pull request Jul 29, 2022
Closed
@flaneur2020 flaneur2020 mentioned this pull request Aug 3, 2022
Closed
@mergify mergify bot merged commit 7d39378 into databendlabs:main Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drmingdrmer drmingdrmer drmingdrmer approved these changes

@Xuanwo Xuanwo Xuanwo approved these changes

@BohuTANG BohuTANG Awaiting requested review from BohuTANG

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
4 participants
@flaneur2020 @BohuTANG @drmingdrmer @Xuanwo