Skip to content

fix(planner): Validate duplicated column name when creating table #7307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

leiysky
Copy link
Contributor

@leiysky leiysky commented Aug 26, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Fixes #7247

@vercel
Copy link

vercel bot commented Aug 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Aug 26, 2022 at 6:56AM (UTC)

@mergify mergify bot added the pr-bugfix this PR patches a bug in codebase label Aug 26, 2022
@Xuanwo
Copy link
Member

Xuanwo commented Aug 26, 2022

Unit test failed:

2022-08-26T07:04:53.156977Z ERROR common_tracing::panic_hook: panicked at 'assertion failed: `(left == right)`
  left: `40`,
 right: `30`', src/query/service/tests/it/storages/fuse/pruning.rs:197:9 backtrace=Backtrace [{ fn: "common_tracing::panic_hook::log_panic" }, { fn: "common_tracing::panic_hook::set_panic_hook::{{closure}}" }, { fn: "std::panicking::rust_panic_with_hook", file: "/rustc/ddcbba036aee08f0709f98a92a342a278eae5c05/library/std/src/panicking.rs", line: 702 }, { fn: "std::panicking::begin_panic_handler::{{closure}}", file: "/rustc/ddcbba036aee08f0709f98a92a342a278eae5c05/library/std/src/panicking.rs", line: 588 }, { fn: "std::sys_common::backtrace::__rust_end_short_backtrace", file: "/rustc/ddcbba036aee08f0709f98a92a342a278eae5c05/library/std/src/sys_common/backtrace.rs", line: 138 }, { fn: "rust_begin_unwind", file: "/rustc/ddcbba036aee08f0709f98a92a342a278eae5c05/library/std/src/panicking.rs", line: 584 }, { fn: "core::panicking::panic_fmt", file: "/rustc/ddcbba036aee08f0709f98a92a342a278eae5c05/library/core/src/panicking.rs", line: 142 }, { fn: "core::panicking::assert_failed_inner", file: "/rustc/ddcbba036aee08f0709f98a92a342a278eae5c05/library/core/src/panicking.rs" }, { fn: "core::panicking::assert_failed" }, { fn: "it::storages::fuse::pruning::test_block_pruner::{{closure}}" }, { fn: "<core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll" }, { fn: "<core::pin::Pin<P> as core::future::future::Future>::poll" }, { fn: "tokio::runtime::basic_scheduler::CoreGuard::block_on::{{closure}}::{{closure}}::{{closure}}" }, { fn: "tokio::coop::with_budget::{{closure}}" }, { fn: "std::thread::local::LocalKey<T>::try_with" }, { fn: "std::thread::local::LocalKey<T>::with" }, { fn: "tokio::runtime::basic_scheduler::CoreGuard::block_on::{{closure}}::{{closure}}" }, { fn: "tokio::runtime::basic_scheduler::Context::enter" }, { fn: "tokio::runtime::basic_scheduler::CoreGuard::block_on::{{closure}}" }, { fn: "tokio::runtime::basic_scheduler::CoreGuard::enter::{{closure}}" }, { fn: "tokio::macros::scoped_tls::ScopedKey<T>::set" }, { fn: "tokio::runtime::basic_scheduler::CoreGuard::enter" }, { fn: "tokio::runtime::basic_scheduler::CoreGuard::block_on" }, { fn: "tokio::runtime::basic_scheduler::BasicScheduler::block_on" }, { fn: "tokio::runtime::Runtime::block_on" }, { fn: "it::storages::fuse::pruning::test_block_pruner" }, { fn: "it::storages::fuse::pruning::test_block_pruner::{{closure}}" }, { fn: "core::ops::function::FnOnce::call_once" }, { fn: "core::ops::function::FnOnce::call_once", file: "/rustc/ddcbba036aee08f0709f98a92a342a278eae5c05/library/core/src/ops/function.rs", line: 248 }, { fn: "test::__rust_begin_short_backtrace", file: "/rustc/ddcbba036aee08f0709f98a92a342a278eae5c05/library/test/src/lib.rs", line: 572 }, { fn: "<alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once", file: "/rustc/ddcbba036aee08f0709f98a92a342a278eae5c05/library/alloc/src/boxed.rs", line: 1951 }, { fn: "<core::panic::unwind_safe::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once", file: "/rustc/ddcbba036aee08f0709f98a92a342a278eae5c05/library/core/src/panic/unwind_safe.rs", line: 271 }, { fn: "std::panicking::try::do_call", file: "/rustc/ddcbba036aee08f0709f98a92a342a278eae5c05/library/std/src/panicking.rs", line: 492 }, { fn: "std::panicking::try", file: "/rustc/ddcbba036aee08f0709f98a92a342a278eae5c05/library/std/src/panicking.rs", line: 456 }, { fn: "std::panic::catch_unwind", file: "/rustc/ddcbba036aee08f0709f98a92a342a278eae5c05/library/std/src/panic.rs", line: 137 }, { fn: "test::run_test_in_process", file: "/rustc/ddcbba036aee08f0709f98a92a342a278eae5c05/library/test/src/lib.rs", line: 595 }, { fn: "test::run_test::run_test_inner::{{closure}}", file: "/rustc/ddcbba036aee08f0709f98a92a342a278eae5c05/library/test/src/lib.rs", line: 489 }, { fn: "test::run_test::run_test_inner::{{closure}}", file: "/rustc/ddcbba036aee08f0709f98a92a342a278eae5c05/library/test/src/lib.rs", line: 516 }, { fn: "std::sys_common::backtrace::__rust_begin_short_backtrace", file: "/rustc/ddcbba036aee08f0709f98a92a342a278eae5c05/library/std/src/sys_common/backtrace.rs", line: 122 }, { fn: "std::thread::Builder::spawn_unchecked_::{{closure}}::{{closure}}", file: "/rustc/ddcbba036aee08f0709f98a92a342a278eae5c05/library/std/src/thread/mod.rs", line: 501 }, { fn: "<core::panic::unwind_safe::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once", file: "/rustc/ddcbba036aee08f0709f98a92a342a278eae5c05/library/core/src/panic/unwind_safe.rs", line: 271 }, { fn: "std::panicking::try::do_call", file: "/rustc/ddcbba036aee08f0709f98a92a342a278eae5c05/library/std/src/panicking.rs", line: 492 }, { fn: "std::panicking::try", file: "/rustc/ddcbba036aee08f0709f98a92a342a278eae5c05/library/std/src/panicking.rs", line: 456 }, { fn: "std::panic::catch_unwind", file: "/rustc/ddcbba036aee08f0709f98a92a342a278eae5c05/library/std/src/panic.rs", line: 137 }, { fn: "std::thread::Builder::spawn_unchecked_::{{closure}}", file: "/rustc/ddcbba036aee08f0709f98a92a342a278eae5c05/library/std/src/thread/mod.rs", line: 500 }, { fn: "core::ops::function::FnOnce::call_once{{vtable.shim}}", file: "/rustc/ddcbba036aee08f0709f98a92a342a278eae5c05/library/core/src/ops/function.rs", line: 248 }, { fn: "<alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once", file: "/rustc/ddcbba036aee08f0709f98a92a342a278eae5c05/library/alloc/src/boxed.rs", line: 1951 }, { fn: "<alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once", file: "/rustc/ddcbba036aee08f0709f98a92a342a278eae5c05/library/alloc/src/boxed.rs", line: 1951 }, { fn: "std::sys::unix::thread::Thread::new::thread_start", file: "/rustc/ddcbba036aee08f0709f98a92a342a278eae5c05/library/std/src/sys/unix/thread.rs", line: 108 }, { fn: "start_thread" }, { fn: "clone" }] panic.file="src/query/service/tests/it/storages/fuse/pruning.rs" panic.line=197 panic.column=9
test storages::fuse::pruning::test_block_pruner ... FAILED

@sundy-li
Copy link
Member

Unit test failed:

Will be fixed in #7273 , let's merge this first.

@sundy-li sundy-li merged commit 3af1e5b into databendlabs:main Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

duplicated column name validation
5 participants