-
Notifications
You must be signed in to change notification settings - Fork 771
feat: try to improve object storage io read #9335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
f5851df
to
64082b5
Compare
d84f0bc
to
8954309
Compare
This comment was marked as outdated.
This comment was marked as outdated.
7d6972b
to
c71b577
Compare
4d5aad6
to
5349116
Compare
This comment was marked as outdated.
This comment was marked as outdated.
@mergify update |
✅ Branch has been successfully updated |
14a7ab5
to
084b6cd
Compare
@mergify update |
✅ Branch has been successfully updated |
@mergify update |
✅ Branch has been successfully updated |
zhang2014
reviewed
Dec 26, 2022
zhang2014
approved these changes
Dec 26, 2022
50 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Try to merge neighboring io operations using RangeMerger
storage_io_min_bytes_for_seek
, then Databend sequentially reads a range of files that contains both ranges, thus avoiding extra seek.Introduce two remote read IO settings
storage_io_min_bytes_for_seek
: If the distance between two IO requests to be read in one file is less than storage_io_min_bytes_for_seek, merge them into one, the default value is 512Bytes.storage_io_max_page_bytes_for_read
: The maximum bytes of one IO request to read. Default the value is 512KBIntroduce remote IO request perf counter
Case1:
For this query, the total IO time was from 546271.0ms to 446209.0ms(after Merged IO).
Case2:
Bench
Nightly-162 vs. This PR
Closes #9308