Skip to content

feat(query): support array_sort #9941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 12, 2023
Merged

feat(query): support array_sort #9941

merged 5 commits into from
Feb 12, 2023

Conversation

TCeason
Copy link
Collaborator

@TCeason TCeason commented Feb 9, 2023 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

array_sort(array, ('ASC'|'DESC'), ('NULLS FIRST'|'NULLS LAST')) Sorts the elements of the array. array_sort([3, 6, 1, 2]) [1, 2, 3, 6]

Closes #9940

@vercel
Copy link

vercel bot commented Feb 9, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
databend ⬜️ Ignored (Inspect) Feb 12, 2023 at 0:59AM (UTC)

@TCeason TCeason requested a review from b41sh February 9, 2023 05:20
@mergify
Copy link
Contributor

mergify bot commented Feb 9, 2023

This pull request's title is not fulfill the requirements. @TCeason please update it 🙏.

Valid format:

fix(query): fix group by string bug
  ^         ^---------------------^
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: rfc, feat, fix, refactor, ci, docs, chore

Valid types:

  • rfc: this PR proposes a new RFC
  • feat: this PR introduces a new feature to the codebase
  • fix: this PR patches a bug in codebase
  • refactor: this PR changes the code base without new features or bugfix
  • ci: this PR changes build/testing/ci steps
  • docs: this PR changes the documents or websites
  • chore: this PR only has small changes that no need to record

@TCeason TCeason changed the title support array_sort feat(query): support array_sort Feb 9, 2023
@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Feb 9, 2023
@TCeason TCeason marked this pull request as draft February 9, 2023 08:34
@TCeason TCeason force-pushed the array_sort branch 2 times, most recently from 7b36ecd to 34cdcde Compare February 11, 2023 01:19
@TCeason TCeason marked this pull request as ready for review February 11, 2023 01:20
@TCeason TCeason requested review from andylokandy and b41sh February 11, 2023 01:20
@TCeason
Copy link
Collaborator Author

TCeason commented Feb 11, 2023

@soyeric128 Please add this func into array doc.

@TCeason TCeason mentioned this pull request Feb 11, 2023
Closed
@TCeason TCeason requested a review from xudong963 February 11, 2023 01:27
@TCeason TCeason force-pushed the array_sort branch 2 times, most recently from 774b6fd to a983df8 Compare February 11, 2023 10:21
b41sh
b41sh reviewed Feb 11, 2023
View reviewed changes
@TCeason TCeason force-pushed the array_sort branch 2 times, most recently from 7bdb6b7 to d1c4104 Compare February 11, 2023 15:06
@sundy-li sundy-li merged commit 5ed4b04 into databendlabs:main Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b41sh b41sh b41sh approved these changes

@andylokandy andylokandy andylokandy approved these changes

@xudong963 xudong963 Awaiting requested review from xudong963

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

array_sort(array)
4 participants
@TCeason @b41sh @andylokandy @sundy-li