Skip to content

[Feature] Add datasource databricks_users #4537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 45 commits into
base: main
Choose a base branch
from
Open

[Feature] Add datasource databricks_users #4537

wants to merge 45 commits into from

Conversation

nkvuong
Copy link
Contributor

@nkvuong nkvuong commented Feb 27, 2025 •
edited
Loading

Changes

Continuing #4028
Added databricks_users data source as requested in #3468 to retrieve multiple users from both the account and workspace-level APIs with optional filtering by display_name_contains or user_name_contains, enabling bulk user management operations.

Closes #3468

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

dgomez04 and others added 30 commits October 23, 2024 12:27
@dgomez04
#3468: added initial data_users.go resource
05f70c1
@dgomez04
#3468: made changes to data_users.go to explicitly define schema, and…
f2dd1c2 
… only request the id, userName, and displayName attributes. added succesful initial test_case on data_users_test.go
@dgomez04
#3468: added 'user_name_contains' attribute to data_users.go to allow…
2d594a9 
… filtering by userName, and added additional test cases on data_users_test.go
@dgomez04
#3468: added acceptance tests for data_users
0d6f280
@dgomez04
#3468: added documentation for databricks_users data source.
b6380f8
@dgomez04
renamed resource func to DataSourceUsers, removed various acceptance …
1c703b4 
…tests, and added the resource definition into the provider
@dgomez04
added correct reference to data resource 'databricks_users' on the ac…
dbd79d8 
…ceptance test.
@dgomez04
name format changes to acceptance tests
4ed08d4
@dgomez04
modified acceptance test
072123a
@dgomez04
fixed integration test to point to correct import
bffcf54
@dgomez04
#3468: started migrating to the plugin framework, adding support for …
7fa5823 
…workspace-level and account-level provider.
@dgomez04
migrated data_users to plugin framework and added support for both pr…
1c58eaa 
…oviders.
@dgomez04
deleted sdkv2 'data_users' and removed it from sdkv2.go
c2d70b9
@dgomez04
migrated test
4ab1e27
@dgomez04
added acceptance tests and added the data source to pluginfw.go
8db0188
@dgomez04
modified docs to reflect changes
2e46921
@dgomez04
Merge branch 'main' into feature/3468-databricks_users
ed587ee
@dgomez04
added correct attributes to the docs
6e4b8ed
@dgomez04
added correct attributes to the docs
5604c68
@dgomez04
Merge remote-tracking branch 'origin/feature/3468-databricks_users' i…
f285db5 
…nto feature/3468-databricks_users
@dgomez04
Merge branch 'main' into feature/3468-databricks_users
a628819
@dgomez04
Fix fmton pluginfw.go
d5ac8b4 
Fix `fmt`.
@dgomez04
merged upstream
32e79f6
@dgomez04
merged with upstream
6f6d19e
@dgomez04
removed unnecesary tests, switched to use a filter field to leverage …
88608c1 
…REST API's flexibility
@dgomez04
added resource to rollout utils
26c69fb
@dgomez04
updated docs to reflect changes
9e54137
@dgomez04
added requested changes
43b66ec
@dgomez04
merged upstream and resolved conflicts
27f6d32
@dgomez04
Merge remote-tracking branch 'upstream/main' into feature/3468-databr…
7a47c2a 
…icks_users
@nkvuong nkvuong temporarily deployed to test-trigger-is March 12, 2025 06:52 — with GitHub Actions Inactive
@nkvuong nkvuong temporarily deployed to test-trigger-is March 12, 2025 06:54 — with GitHub Actions Inactive
@nkvuong nkvuong temporarily deployed to test-trigger-is March 12, 2025 07:00 — with GitHub Actions Inactive
@nkvuong nkvuong temporarily deployed to test-trigger-is March 12, 2025 07:02 — with GitHub Actions Inactive
@nkvuong nkvuong temporarily deployed to test-trigger-is March 13, 2025 15:20 — with GitHub Actions Inactive
@nkvuong nkvuong temporarily deployed to test-trigger-is March 13, 2025 15:20 — with GitHub Actions Inactive
@alexott alexott temporarily deployed to test-trigger-is March 17, 2025 11:49 — with GitHub Actions Inactive
@alexott alexott temporarily deployed to test-trigger-is March 17, 2025 11:50 — with GitHub Actions Inactive
@nkvuong
Copy link
Contributor Author

nkvuong commented Mar 21, 2025

There is an issue with the tfsdk structs generated for SCIM

@alexott alexott temporarily deployed to test-trigger-is May 20, 2025 17:29 — with GitHub Actions Inactive
@alexott alexott temporarily deployed to test-trigger-is May 20, 2025 17:29 — with GitHub Actions Inactive
@alexott alexott temporarily deployed to test-trigger-is May 21, 2025 14:15 — with GitHub Actions Inactive
@alexott alexott temporarily deployed to test-trigger-is May 21, 2025 14:16 — with GitHub Actions Inactive
@alexott alexott temporarily deployed to test-trigger-is May 28, 2025 10:33 — with GitHub Actions Inactive
@alexott alexott temporarily deployed to test-trigger-is May 28, 2025 10:34 — with GitHub Actions Inactive
alexott
alexott approved these changes May 28, 2025
View reviewed changes
Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comments

@alexott alexott temporarily deployed to test-trigger-is June 2, 2025 16:15 — with GitHub Actions Inactive
@alexott alexott temporarily deployed to test-trigger-is June 2, 2025 16:15 — with GitHub Actions Inactive
@alexott alexott temporarily deployed to test-trigger-is June 3, 2025 06:19 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2025

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4537
  • Commit SHA: 340763e12ff5ebe76d08734c2597bcb086d93e7b

Checks will be approved automatically on success.

@alexott alexott deployed to test-trigger-is June 3, 2025 06:20 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@alexott alexott alexott approved these changes

@parthban-db parthban-db Awaiting requested review from parthban-db parthban-db is a code owner automatically assigned from databricks/eng-plat-auto-exp-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] New data block databricks_users
3 participants
@nkvuong @alexott @dgomez04