Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

Update README.md #876

Merged
merged 2 commits into from
Mar 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -170,18 +170,11 @@ Check out [documentation](https://docs.datafold.com/reference/open_source/cli) f
| Trino | 🟡 | `trino://<username>:<password>@<hostname>:8080/<database>` |
| Clickhouse | 🟡 | `clickhouse://<username>:<password>@<hostname>:9000/<database>` |
| Vertica | 🟡 | `vertica://<username>:<password>@<hostname>:5433/<database>` |
| ElasticSearch | 📝 | |
| Planetscale | 📝 | |
| Pinot | 📝 | |
| Druid | 📝 | | |
| SQLite | 📝 | |

*MS SQL Server support is limited, with known performance issues that are addressed in Datafold Cloud.

* 🟢: Implemented and thoroughly tested.
* 🟡: Implemented, but not thoroughly tested yet.
* ⏳: Implementation in progress.
* 📝: Implementation planned. Contributions welcome.

Your database not listed here?

Expand Down
9 changes: 3 additions & 6 deletions data_diff/cloud/data_source.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,18 +90,15 @@ def create_ds_config(


@overload
def _cast_value(value: str, type_: Literal["integer"]) -> int:
...
def _cast_value(value: str, type_: Literal["integer"]) -> int: ...


@overload
def _cast_value(value: str, type_: Literal["boolean"]) -> bool:
...
def _cast_value(value: str, type_: Literal["boolean"]) -> bool: ...


@overload
def _cast_value(value: str, type_: Literal["string"]) -> str:
...
def _cast_value(value: str, type_: Literal["string"]) -> str: ...


def _cast_value(value: str, type_: str) -> Union[bool, int, str]:
Expand Down
7 changes: 3 additions & 4 deletions data_diff/diff_tables.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
"""Provides classes for performing a table diff
"""
"""Provides classes for performing a table diff"""

import threading
import time
from abc import ABC, abstractmethod
Expand Down Expand Up @@ -284,8 +284,7 @@ def _diff_segments(
level=0,
segment_index=None,
segment_count=None,
):
...
): ...

def _bisect_and_diff_tables(self, table1: TableSegment, table2: TableSegment, info_tree):
if len(table1.key_columns) != len(table2.key_columns):
Expand Down
3 changes: 1 addition & 2 deletions data_diff/joindiff_tables.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
"""Provides classes for performing a table diff using JOIN
"""Provides classes for performing a table diff using JOIN"""

"""
from decimal import Decimal
from functools import partial
import logging
Expand Down
1 change: 1 addition & 0 deletions data_diff/queries/extras.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
"Useful AST classes that don't quite fall within the scope of regular SQL"

from typing import Callable, Optional, Sequence

import attrs
Expand Down
4 changes: 1 addition & 3 deletions data_diff/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,7 @@ def match_regexps(regexps: Dict[str, Any], s: str) -> Sequence[tuple]:

class CaseAwareMapping(MutableMapping[str, V]):
@abstractmethod
def get_key(self, key: str) -> str:
...
def get_key(self, key: str) -> str: ...

def new(self, initial=()) -> Self:
return type(self)(initial)
Expand Down Expand Up @@ -416,7 +415,6 @@ def get_from_dict_with_raise(dictionary: Dict, key: str, exception: Exception):


class Vector(tuple):

"""Immutable implementation of a regular vector over any arithmetic value

Implements a product order - https://en.wikipedia.org/wiki/Product_order
Expand Down