Dev 846 release ci fix #1216
Dev 846 release ci fix #1216
Conversation
| @@ -28,7 +28,7 @@ | |||
| // "runServices": [], | |||
| // Uncomment the next line if you want to keep your containers running after VS Code shuts down. | |||
| "shutdownAction": "stopCompose", | |||
| "onCreateCommand": "python3 -m pip install -q -e .[test]", | |||
| "onCreateCommand": "python3 -m pip install -q -e .[dev]", | |||
There was a problem hiding this comment.
pyproject optional_dependency added dev and test for different use case
| @@ -0,0 +1,125 @@ | |||
| name: Release | |||
| on: | |||
| workflow_dispatch: | |||
There was a problem hiding this comment.
Manual trigger + optionally release to TestPyPI
| asset_name: pip-datajoint-${{env.DJ_VERSION}}.tar.gz | ||
| asset_content_type: application/gzip | ||
| # only release docs when a release is published | ||
| call-publish-docs: |
There was a problem hiding this comment.
Consolidated previous duplicated doc release step, this is going to reuse the manual doc release workflow
| @@ -0,0 +1,53 @@ | |||
| name: Test | |||
| on: | |||
There was a problem hiding this comment.
Test will be triggered on every push and open/update PR
.github/workflows/test.yaml
Outdated
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-python@v5 | ||
| # enforce the same check as pre-commit | ||
| # but only run important checks |
There was a problem hiding this comment.
Reuse pre-commit, but only run codespell, black and flake8 - doing exactly the same as previous development.yaml
| tqdm(desc="Processes: ", total=nkeys) | ||
| if display_progress | ||
| else contextlib.nullcontext() | ||
| ) as progress_bar: |
There was a problem hiding this comment.
Once changed pyproject.toml:require-python from >=3.8 to 3.9, black fails on format check, so update the format here, and only here
| ] | ||
|
|
||
| [project.urls] | ||
| Homepage = "https://datajoint.com/docs" | ||
| Documentation = "https://datajoint.com/docs" | ||
| Repository = "https://github.com/datajoint/datajoint-python" | ||
| "Bug Tracker" = "https://github.com/datajoint/datajoint-python/issues" | ||
| Changelog = "https://github.com/datajoint/datajoint-python/blob/master/CHANGELOG.md" | ||
| "Release Notes" = "https://github.com/datajoint/datajoint-python/releases" |
There was a problem hiding this comment.
We are going to use git-diff as changelog like minio/minio-py@7.2.14...7.2.15, and it will be at the end of a release note like https://github.com/minio/minio-py/releases, so putting release notes here instead
| run: | | ||
| DJ_VERSION=$(grep -oP '\d+\.\d+\.\d+' datajoint/version.py) | ||
| RELEASE_BODY=$(python -c \ | ||
| 'print(open("./CHANGELOG.md").read().split("\n\n")[1].split("\n", 1)[1])' \ |
There was a problem hiding this comment.
"Changelog in release note" isn't ready yet, will be available very soon. If release before that, please update changelog as usual
Change Summary: